Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activerecord: Add ActiveRecord::QueryMethods#with #652

Merged
merged 2 commits into from
Oct 3, 2024
Merged

activerecord: Add ActiveRecord::QueryMethods#with #652

merged 2 commits into from
Oct 3, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Sep 7, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

@tk0miya Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

ksss
ksss reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions GitHub Actions
Copy link

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya
Copy link
Contributor Author

tk0miya commented Sep 10, 2024

/merge

@github-actions GitHub Actions
Copy link

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.

See the Actions tab for detail.

@tk0miya
Copy link
Contributor Author

tk0miya commented Sep 10, 2024

Oops... we need to re-approve if I fixed the conflicts.

@ksss could you review this again, please?

tk0miya added a commit to tk0miya/gem_rbs_collection that referenced this pull request Sep 30, 2024
@tk0miya
activerecord: Apply recent changes to AR 7.2
a8f009b 
refs:

* ruby#652
* ruby#655
* ruby#659
* ruby#660
@tk0miya tk0miya mentioned this pull request Sep 30, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@tk0miya
activerecord: Apply recent changes to AR 7.2 (#676)
aa6a933 
refs:

* #652
* #655
* #659
* #660
ksss
ksss reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 3, 2024

/merge

@github-actions github-actions bot merged commit 6473f69 into ruby:main Oct 3, 2024
4 checks passed
@tk0miya tk0miya deleted the activerecord/with branch October 3, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksss ksss ksss left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @ksss