activerecord: Support insert_all on relation #658
Merged
+117
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveRecord supports insert and upsert methods on relation classes (AssociationRelation and CollectionProxy) since v6.1. refs: * rails/rails#38899 * https://github.com/rails/rails/blob/v6.1.7.8/activerecord/CHANGELOG.md Note: The implementation will be moved into AR::Relation since v7.2.
|
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
|
/merge |
tk0miya
added a commit
to tk0miya/gem_rbs_collection
that referenced
this pull request
Sep 11, 2024
ActiveRecord supports insert and upsert methods on relation classes (AssociationRelation and CollectionProxy) since v6.1. The implementation of insert_all has been changed since v7.2. The implementation was moved to AR::Relation from AR::Persistence. So types follow the new structure. refs: * ruby#658 * rails/rails#38899 * rails/rails#51805 * https://github.com/rails/rails/blob/v6.1.7.8/activerecord/CHANGELOG.md
tk0miya
added a commit
to tk0miya/gem_rbs_collection
that referenced
this pull request
Sep 11, 2024
ActiveRecord supports insert and upsert methods on relation classes (AssociationRelation and CollectionProxy) since v6.1. The implementation of insert_all has been changed since v7.2. The implementation was moved to AR::Relation from AR::Persistence. So types follow the new structure. refs: * ruby#658 * rails/rails#38899 * rails/rails#51805 * https://github.com/rails/rails/blob/v6.1.7.8/activerecord/CHANGELOG.md
tk0miya
added a commit
to tk0miya/gem_rbs_collection
that referenced
this pull request
Sep 11, 2024
ActiveRecord supports insert and upsert methods on relation classes (AssociationRelation and CollectionProxy) since v6.1. The implementation of insert_all has been changed since v7.2. The implementation was moved to AR::Relation from AR::Persistence. So types follow the new structure. refs: * ruby#658 * rails/rails#38899 * rails/rails#51805 * https://github.com/rails/rails/blob/v6.1.7.8/activerecord/CHANGELOG.md
github-actions bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
ActiveRecord supports insert and upsert methods on relation classes (AssociationRelation and CollectionProxy) since v6.1. The implementation of insert_all has been changed since v7.2. The implementation was moved to AR::Relation from AR::Persistence. So types follow the new structure. refs: * #658 * rails/rails#38899 * rails/rails#51805 * https://github.com/rails/rails/blob/v6.1.7.8/activerecord/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecord supports insert and upsert methods on relation classes (AssociationRelation and CollectionProxy) since v6.1.
refs:
Note:
The implementation will be moved into AR::Relation since v7.2.