Update instructions for defining classes and modules init_new_gem #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I often wonder whether to split the definitions into multiple files or combine them into a single RBS file. Of course, this depends on the size of the gem or the preferences of the first gem's RBS contributor. Therefore, I think it's worth noting both strategies in the generated RBS file.
|
@yykamei Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
You changed non-gem files. @pocke, please review and approve the changes. |
pocke
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often wonder whether to split the definitions into multiple files or combine them into a single RBS file.
Of course, this depends on the size of the gem or the preferences of the first gem's RBS contributor. Therefore, I think it's worth noting both strategies in the generated RBS file.