Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Parser::Source::Buffer #664

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Improve Parser::Source::Buffer #664

merged 1 commit into from
Sep 17, 2024

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Sep 12, 2024

I focused on the public API (documented API) and added methods.

@github-actions GitHub Actions
Copy link

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

parser

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@pocke, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@pocke pocke merged commit f5ccba0 into ruby:main Sep 17, 2024
5 checks passed
@ksss ksss deleted the parser-buffer branch September 17, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @pocke