activesupport: Update the type of Array.wrap #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, `Array.wrap` will be return an empty tuple for untyped value
because it matches to the first method_type: `(nil) -> []`.
In the type world, the behavior of an empty tuple is different from an
empty array. For example, calling a enumerable method will cause type
an error:
```
app/app.rb:18:28: [error] Type `bot` does not have method `to_s`
│ Diagnostic ID: Ruby::NoMethod
│
└ Array.wrap(foo).map { |e| e.to_s }
~~~~
```
This changes the return type of `Array.wrap` for nil value to
`Array[untyped]`.
refs: ruby#683
|
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
|
@nickjer What do you think about this change? |
tk0miya
commented
Oct 8, 2024
ksss
reviewed
Oct 10, 2024
this also changes the case of `[T] (T ele) -> [T]` to `-> Array[T]`
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present,
Array.wrapwill be return an empty tuple for untyped value because it matches to the first method_type:(nil) -> [].In the type world, the behavior of an empty tuple is different from an empty array. For example, calling a enumerable method will cause type an error:
This changes the return type of
Array.wrapfor nil value toArray[untyped].refs: #683