Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

railties: Add Rails::Railties.initializers #693

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Oct 20, 2024

We need to call "extend ClassMethods" manually to add Rails::Railties.initializers.

Copy link

@tk0miya Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

railties

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

gems/railties/6.0/patch.rbs Outdated Show resolved Hide resolved
tk0miya added a commit to tk0miya/gem_rbs_collection that referenced this pull request Oct 24, 2024
….rbs

As a preparation of ruby#693, this moves the definition of
`Rails::Generator::PluginGenerator#app_path` to railties.rbs
tk0miya added a commit to tk0miya/gem_rbs_collection that referenced this pull request Oct 28, 2024
….rbs

As a preparation of ruby#693, this moves the definition of
`Rails::Generator::PluginGenerator#app_path` to railties.rbs
tk0miya added a commit to tk0miya/gem_rbs_collection that referenced this pull request Oct 30, 2024
….rbs

As a preparation of ruby#693, this moves the definition of
`Rails::Generator::PluginGenerator#app_path` to railties.rbs
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
….rbs (#697)

As a preparation of #693, this moves the definition of
`Rails::Generator::PluginGenerator#app_path` to railties.rbs
We need to call "extend ClassMethods" manually to add
`Rails::Railties.initializers`.
@tk0miya tk0miya force-pushed the railties/Railties.initializers branch from 794fe70 to 38fcba8 Compare October 30, 2024 02:35
@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 30, 2024

Now I moved the new definition to railities.rbs

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 30, 2024

/merge

@github-actions github-actions bot merged commit ec0da81 into ruby:main Oct 30, 2024
4 checks passed
@tk0miya tk0miya deleted the railties/Railties.initializers branch October 30, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants