activemodel: ActiveModel::Errors#add accepts String and Proc for type #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanfrecce-osaka Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
sanfrecce-osaka
force-pushed
the
fix-activemodel-errors-add
branch
from
d783e3c
to
0b39c22
Compare
… type The behavior of passing String or Proc for type should be allowed. FYI: It is documented in 6.1, but It is already available in 6.0. cf. rails/rails@fcd1e41#diff-4deafad6fefcf6aa6626a1f7e3cd0ca1cf95e358f55a10a69e02be84d926bb31R368-R374 cf. rails/rails@d9011e3#diff-4deafad6fefcf6aa6626a1f7e3cd0ca1cf95e358f55a10a69e02be84d926bb31R370 Also, the name of the second argument was changed from `message` to `type` in 6.1.
sanfrecce-osaka
force-pushed
the
fix-activemodel-errors-add
branch
from
0b39c22
to
fe5bb2d
Compare
ksss
reviewed
Nov 12, 2024
| # # => {:base=>["either name or email must be present"]} | ||
| # person.errors.details | ||
| # # => {:base=>[{error: :name_or_email_blank}]} | ||
| def add: (untyped attribute, ?::Symbol | ::String | ^(untyped base, ::Hash[untyped, untyped]) -> (::Symbol | ::String) type, ?::Hash[untyped, untyped] options) -> void |
There was a problem hiding this comment.
What makes you think return type should be void instead of ActiveModel::Error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of passing String or Proc for type should be allowed.
FYI: It is documented in 6.1, but It is already available in 6.0.
cf. rails/rails@fcd1e41#diff-4deafad6fefcf6aa6626a1f7e3cd0ca1cf95e358f55a10a69e02be84d926bb31R368-R374
cf. rails/rails@d9011e3#diff-4deafad6fefcf6aa6626a1f7e3cd0ca1cf95e358f55a10a69e02be84d926bb31R370
Also, the name of the second argument was changed from
messagetotypein 6.1.