activerecord: CollectionProxy#build can take an array of EachPair #718
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described above, `CollectionProxy#build` takes an array of attributes and returns list of instances of the model.
|
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
ksss
reviewed
Nov 12, 2024
Comment on lines
+828
to
+829
| def build: (?Array[_EachPair] attributes) ?{ () -> untyped } -> Array[untyped] | ||
| | (?_EachPair attributes) ?{ () -> untyped } -> untyped |
There was a problem hiding this comment.
It looks like you have created the possibility to return an Array even when there are no arguments, is this intentional?
person.pets.build #=> Array[untyped]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described above,
CollectionProxy#buildtakes an array of attributes and returns list of instances of the model.