Revert "A temporary workaround to download OpenSSL archive files." #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was told that OpenSSL project resolved the website issue at <openssl/openssl#24984 (comment)>. This reverts commit f2c7729.
|
Good to hear! Regardless, I wonder if we should switch to using GitHub for newer OpenSSL releases if it now is the primary location. |
Yes, as the GitHub releases are the primary locations to download, using GitHub releases makes sense to me. As I said at #778 (comment), the links to the openssl-1.0.2u.tar.gz and openssl-1.1.0l.tar.gz are missing on https://github.com/openssl/openssl/releases . And it seems the link format is different between OpenSSL 3.x and OpenSSL 1.1.1w. However, we may be able to apply the links to the https://github.com/openssl/openssl/releases conditionally only for the OpenSSL 3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was told that OpenSSL project resolved the website issue at openssl/openssl#24984 (comment).
This reverts commit f2c7729.
I checked this reverting commit worked on the CI in my forked repository.
https://github.com/junaruga/ruby-openssl/actions/runs/10080561249