Fix test_provider.rb in FIPS. #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
reviewed
Sep 5, 2024
junaruga
force-pushed
the
wip/fips-test-provider
branch
4 times, most recently
from
a3d8c58
to
15a2a76
Compare
|
@rhenium I fixed all the items that you mentioned in the review. |
junaruga
force-pushed
the
wip/fips-test-provider
branch
from
15a2a76
to
7bdbc52
Compare
|
Merged, thank you! |
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the
test/openssl/test_provider.rbin FIPS cases.There are 2 commits. The 1st commit is the same with the PR #790. The 1st commit is a temporary workaround. I expect the PR #790 will be merged soon first before this PR is reviewed. The 2nd commit is the main commit for this PR.