Make rand(Integer)
returns Integer
#2007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1982
The
rand
implementation is a bit annoying for type checkers.The current type definition is sound that
rand(1)
returnsInteger | Float
, while it's really annoying because it returnsInteger
actually.To make the type checkers more useful and match with our intuition, this PR makes the
rand(1)
returnsInteger
.We assume the following pattern:
Float
result, we usually pass0
literal torand
--rand(0)
should return anFloat
0
, because we don't wantFloat
result --rand(i)
can returnInteger
, noFloat
The type definition uses literal type
0
to make type ofrand(0)
callFloat
. And otherInteger
cases returns anInteger
.This is unsound, but we believe this is more practical and useful.