Add tests for combination of {bin,text}mode and external_encoding in ... #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IO.new The encoding option takes precedence over the binmode/textmode options. There are similar tests for passing the binmode argument in the mode argument.
| @@ -208,6 +208,26 @@ | |||
| @io.internal_encoding.to_s.should == 'IBM866' | |||
| end | |||
|
|
|||
| it "does not use binmode argument when mode encoding is specified" do | |||
There was a problem hiding this comment.
suggestion:
Suggested change
| it "does not use binmode argument when mode encoding is specified" do | |
| it "does not use binary encoding when mode encoding is specified along with binmode: true option" do |
Actually it uses the binmode argument and #binmode? will return a specified value. But it doesn't affect io encoding.
There is a test for "b" mode and internal_encoding. Shouldn't we have a similar case with binmode/textmode options as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…IO.new
The encoding option takes precedence over the binmode/textmode options. There are similar tests for passing the binmode argument in the mode argument.