Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for Data#to_h #1196

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add specs for Data#to_h #1196

merged 1 commit into from
Sep 30, 2024

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Sep 25, 2024

No description provided.

andrykonchin
andrykonchin approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@andrykonchin andrykonchin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The method also accepts a block:

to_h {|name, value| ... } → hash

So this test seems not complete (and core/hash/to_h_spec.rb or similar could be used as example).

@herwinw
Copy link
Member Author

herwinw commented Sep 25, 2024

I've added the tests for the block, very much inspired by Hash#to_h

@andrykonchin
Copy link
Member

Looks great! Thank you.

@andrykonchin andrykonchin merged commit 7215241 into ruby:master Sep 30, 2024
14 checks passed
@herwinw herwinw deleted the data_to_h branch October 1, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrykonchin andrykonchin Awaiting requested review from andrykonchin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herwinw @andrykonchin