Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed default for Encoding.default_external to UTF-8 on Windows #854

Merged
merged 2 commits into from
Oct 5, 2021
Merged

changed default for Encoding.default_external to UTF-8 on Windows #854

merged 2 commits into from
Oct 5, 2021

Conversation

moofkit
Copy link
Contributor

@moofkit moofkit commented Oct 5, 2021 •
edited
Loading

Solving #823

Changed default for Encoding.default_external to UTF-8 on Windows [Feature #16604]

@moofkit moofkit marked this pull request as ready for review October 5, 2021 16:20
eregon
eregon approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit c687af8 into ruby:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moofkit @eregon