Add spec for feature 17187 #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 15, 2021
| @socket = TCPSocket.send(@method, @hostname, @server.port, connect_timeout: 1) | ||
| @socket.should be_an_instance_of(TCPSocket) | ||
| end | ||
| end |
There was a problem hiding this comment.
This is a good start, but we should also test what happens if it does actually time out.
I think that should be easy to emulate with a manual TCPServer.new/TCPServer.open (see the logic in SpecTCPServer to get port and hostname),
and then never calling accept.
Then we should get an exception after the specified timeout.
Would you like to try adding that?
There was a problem hiding this comment.
Interesting, #877 added something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This is my attempt for #823
Feature 17187