Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround: Fix test failures on Ubuntu jammy s390x. #63

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Workaround: Fix test failures on Ubuntu jammy s390x. #63

merged 2 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Workaround: Fix test failures on Ubuntu jammy s390x. 

    This commit fixes the test failures on the zlib in Ubuntu jammy s390x.

According to the <https://packages.ubuntu.com/jammy-updates/zlib1g> -
`zlib_1.2.11.dfsg-2ubuntu9.2.debian.tar.xz`,
the zlib deb package is applying the patch 410.patch (madler/zlib#410), and
configured by `./configure --dfltcc` on Ubuntu jammy s390x. The `--dfltcc`
is to enable the deflate algorithm in hardware.

It produces a different (but still valid) compressed byte stream, and causes
the test failures in ruby/zlib. As a workaround, set the environment variable
`DFLTCC=0` disabling the implementation in zlib on s390x to the failing tests.

Note we need to test in a child Ruby process with `assert_separately` to test
on the `DFLTCC=0` set by the parent Ruby process.
    @junaruga
    junaruga committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9f3b9c4 View commit details
    Browse the repository at this point in the history

  2. .travis.yml: Add Ubuntu jammy s390x. 

    The only choice to test s390x on pull-request is currently Travis CI as far as
I know.
    @junaruga
    junaruga committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    cc88b54 View commit details
    Browse the repository at this point in the history