Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send correct inputType when typing #244

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

lindagruenwald
Copy link
Contributor

@lindagruenwald lindagruenwald commented Sep 20, 2023

When typing in an input field, the browser usually sends an input event with a specific inputType, e.g. "insertText" when adding characters, "deleteContentBackward" when backspacing, among others.

When using set or fill_in on a field, Cuprite is currently triggering the event in a way that leaves inputType as undefined, which is (unfortunately) what Chrome actually sends on autocompletion. The mostly correct way to trigger this event here should be with "insertText".

@route
Copy link
Member

route commented Sep 22, 2023

Let's see the tests ;)

@route route merged commit 7326bff into rubycdp:main Sep 22, 2023
6 checks passed
@route
Copy link
Member

route commented Sep 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants