chore: add changelog entry

rubycdp · Nov 9, 2023 · 98a7acb · 98a7acb
1 parent 2f9e94f
commit 98a7acb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
   - `#set_behavior` where and whether to store file
 
 ### Changed
+- `Ferrum::Page#screeshot` accepts :area option [#410]
 
 ### Fixed
 

diff --git a/lib/ferrum/page/screenshot.rb b/lib/ferrum/page/screenshot.rb
@@ -5,8 +5,8 @@
 module Ferrum
   class Page
     module Screenshot
-      PARTIAL_SCREENSHOT_ARGUMENTS_MESSAGE = "Ignoring :selector or :area in #screenshot since full: true was given at "
-      AREA_SCREENSHOT_ARGUMENT_MESSAGE = "Ignoring :area in #screenshot since selector: was given at "
+      FULL_WARNING = "Ignoring :selector or :area in #screenshot since full: true was given at %s"
+      AREA_WARNING = "Ignoring :area in #screenshot since selector: was given at %s"
 
       DEFAULT_PDF_OPTIONS = {
         landscape: false,
@@ -221,8 +221,8 @@ def format_options(format, path, quality)
       end
 
       def area_options(full, selector, scale, area = nil)
-        warn("#{PARTIAL_SCREENSHOT_ARGUMENTS_MESSAGE}#{caller(1..1).first}") if full && (selector || area)
-        warn("#{AREA_SCREENSHOT_ARGUMENT_MESSAGE}#{caller(1..1).first}") if selector && area
+        warn(FULL_WARNING % caller(1..1).first) if full && (selector || area)
+        warn(AREA_WARNING % caller(1..1).first) if selector && area
 
         clip = if full
                  full_window_area || viewport_area