Fix: Do not expect response for initiatorType Ping requests #417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
HTML supports adding a
ping
attribute to<a>
tags. In such cases, the browser sents a POST request to the set URL(s) before navigating to the new URL (See w3schools doc here and Mozilla docs on initiatorType which includesping
as an option).Unfortunately, because these requests do not receive a server response Ferrum adds them to the list of
pending_connections
, meaning that subsequent calls towait_for_idle
will timeout waiting for these never-will-complete requests.Changes
Request#response_expected?
method to indicate if the request expects a response from the server (currently 'ping' is the only request I know of that would not get a response)Exchange#response_expected?
that calls the request method. Note, ifrequest.nil?
we default totrue
to match the current behaviourExchange#finished?
so that any requests that do not expect responses are now also considered 'finished'