-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Socialize user profile RFC. #51
Open
simi
wants to merge
1
commit into
master
Choose a base branch
from
soc-user-profile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
- Feature Name: Socialize user profile | ||
- Start Date: 2023-09-30 | ||
- RFC PR: | ||
- Bundler Issue: | ||
|
||
# Summary | ||
|
||
Enhance the RubyGems.org profile by allowing users to include a homepage URL and up to four social network links, inspired by GitHub's approach to profile customization. | ||
|
||
# Motivation | ||
|
||
The evolution and growth of the developer community underscore the importance of developers establishing a comprehensive online presence. Beyond just gem contributions, affiliations to other platforms can boost trust, promote collaborations, and enrich community interactions. This addition also sets the groundwork for future features, like leveraging these social links for enhanced verification mechanisms. | ||
|
||
# Guide-level explanation | ||
|
||
Within the settings of your RubyGems.org profile, you'll find options to: | ||
|
||
- Add a **Homepage URL**: A space for your personal blog, portfolio, or any website you associate with your professional persona. | ||
- Incorporate **Social Network Links**: Four fields where you can link to your social profiles. Recognized platforms (Twitter, Mastodon, LinkedIn, GitHub, GitLab) will display their distinct icons. Links from unrecognized platforms or generic URLs will showcase a universal link icon. | ||
|
||
This enhancement transforms a user's RubyGems profile from merely a gems contribution summary to a broader representation of their professional and social spheres. | ||
|
||
# Reference-level explanation | ||
|
||
For implementation: | ||
|
||
1. Add a new input field designated for the homepage URL. | ||
2. Integrate four input fields specifically for social network links. | ||
3. Initiate a validation mechanism on update: | ||
- Validate URLs for their authenticity and functionality. | ||
- Authenticate the URL structure of known platforms (Twitter, Mastodon, LinkedIn, GitHub, GitLab). | ||
4. Display methodology: | ||
- Determine the domain of each provided link. | ||
- Display the appropriate icon beside each link. For unfamiliar URLs, use a default link icon. | ||
|
||
# Drawbacks | ||
|
||
**Verification Concerns**: The inclusion of external links raises concerns about users potentially linking to unsuitable or misleading content. This might necessitate mechanisms to oversee, report, or exclude harmful links. | ||
|
||
# Rationale and Alternatives | ||
|
||
- **Why this design?**: By mirroring GitHub's approach, this design offers a blend of personalization and clarity. Restricting it to one homepage and four other links ensures profile simplicity while allowing meaningful customization. | ||
- **Alternatives considered**: | ||
- Allow an infinite number of links. (Could clutter profiles) | ||
- Limit to one or two social links. (Might be excessively restrictive) | ||
- **Impact of not doing this**: Without this, RubyGems.org profiles risk being overly focused on gems only. | ||
|
||
# Unresolved questions | ||
|
||
- What mechanisms can we deploy to guarantee the appropriateness of external links? GitHub allows any link with no verification. | ||
- How might these links factor into prospective verification processes in the future? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will tie in super nicely to rubygems/rubygems.org#4062, since it allows for verifying different types of entities. We could allow verifying user links in addition to rubygem links very easily |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would we store 4 links directly on the User model? or add a
CustomLink
table, and allow a user tohave_many :custom_links
and then verify that they only have 4?