Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy user avatar images from gravatar #4599

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Proxy user avatar images from gravatar #4599

merged 1 commit into from
Apr 15, 2024

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Apr 11, 2024 •
edited
Loading

@segiddins segiddins requested review from simi and indirect April 11, 2024 04:44
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.08%. Comparing base (3797f33) to head (bf57de8).
Report is 7 commits behind head on master.

Files Patch % Lines
app/controllers/avatars_controller.rb 97.36% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4599   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files         390      391    +1     
  Lines        8187     8229   +42     
=======================================
+ Hits         7948     7989   +41     
- Misses        239      240    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

indirect
indirect approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thank you! hopefully our avatars will be a little bit less confusing and identical now.

@segiddins segiddins force-pushed the segiddins/proxy-user-avatar-images-from-gravatar branch from 393358a to 330b457 Compare April 11, 2024 04:57
@segiddins segiddins marked this pull request as ready for review April 11, 2024 05:48
colby-swandale
colby-swandale approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad we can get the avatar images back 👏🏻

app/controllers/avatars_controller.rb Outdated Show resolved Hide resolved
martinemde
martinemde approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

app/controllers/avatars_controller.rb Outdated Show resolved Hide resolved
@segiddins segiddins force-pushed the segiddins/proxy-user-avatar-images-from-gravatar branch from 330b457 to bf57de8 Compare April 15, 2024 02:02
@segiddins segiddins merged commit b8d842c into master Apr 15, 2024
17 checks passed
@segiddins segiddins deleted the segiddins/proxy-user-avatar-images-from-gravatar branch April 15, 2024 22:52
@deivid-rodriguez deivid-rodriguez mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colby-swandale colby-swandale colby-swandale approved these changes

@martinemde martinemde martinemde approved these changes

@indirect indirect indirect approved these changes

@simi simi Awaiting requested review from simi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to display profile avatar without displaying email
4 participants
@segiddins @indirect @martinemde @colby-swandale