Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainer Role #4883

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Maintainer Role #4883

wants to merge 28 commits into from

Commits on Sep 16, 2024

  1. Add Access Level field to Ownership table and update RubyGem policies… 

    … to check for the level of access
    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3ddaed4 View commit details
    Browse the repository at this point in the history

  2. Add Ownership edit form to owners table

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bed0451 View commit details
    Browse the repository at this point in the history

  3. Add role field to add Ownership form

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    13dc4a5 View commit details
    Browse the repository at this point in the history

  4. Replace Access Level field with Role

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ead2938 View commit details
    Browse the repository at this point in the history

  5. better validate the role in Owners API endpoint

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    18d4f26 View commit details
    Browse the repository at this point in the history

  6. Refactor Access Level field to be Role instead

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    10d3de0 View commit details
    Browse the repository at this point in the history

  7. Notify users when their Role was updated

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    361310d View commit details
    Browse the repository at this point in the history

  8. Don’t allow a user to update their own Ownership

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    75c540a View commit details
    Browse the repository at this point in the history

  9. prevent maintainers for accessing trusted publishing

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c11b67e View commit details
    Browse the repository at this point in the history

  10. Replace Role type object with an Enum

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3765cb2 View commit details
    Browse the repository at this point in the history

  11. separate checking for onwnership and permissions into separate methods

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ca1ffb4 View commit details
    Browse the repository at this point in the history

  12. Add Minimum Role Scope to the Ownership model 

    Replace the raw sql with something nicer
    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4608d56 View commit details
    Browse the repository at this point in the history

  13. Add translations for Role field

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6d1c10f View commit details
    Browse the repository at this point in the history

  14. Record event when a ownership role is updated

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    20bc75a View commit details
    Browse the repository at this point in the history

  15. Indicate what role the user was updated to in the notification email

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    480db28 View commit details
    Browse the repository at this point in the history

  16. Fix the wrong select values being passed to the edit/create ownership… 

    … form
    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0bbbde0 View commit details
    Browse the repository at this point in the history

  17. Always email owners of any changes to their roles

    @colby-swandale
    colby-swandale committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e37bcc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Fixup breaking test

    @colby-swandale
    colby-swandale committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2508f34 View commit details
    Browse the repository at this point in the history

  2. Remove tests that are no longer relevant

    @colby-swandale
    colby-swandale committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    05e3841 View commit details
    Browse the repository at this point in the history

  3. Fixup migration file name

    @colby-swandale
    colby-swandale committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f766716 View commit details
    Browse the repository at this point in the history

  4. add role to Membership

    @colby-swandale
    colby-swandale committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1c66eca View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Refactor Ownership policies to cover updating user's own ownership 

    Make authorization failures more helpful on ownership changes.
We were sometimes returning just the text 'Forbidden' when
really we need to say that you can't edit your own role or
explain the authorization problem, if possible, then redirect
back to the rubygem page.
    @martinemde
    martinemde committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    3374305 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Improve readability of role access list

    @martinemde
    martinemde committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    c513739 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Add organization policy object

    @colby-swandale
    colby-swandale committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b51fd50 View commit details
    Browse the repository at this point in the history

  2. record the previous value when recording the change role event

    @colby-swandale
    colby-swandale committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    65788ad View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Move method to OrganizationPolicy

    @martinemde
    martinemde committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6f1e863 View commit details
    Browse the repository at this point in the history

  2. Fix new lint error

    @martinemde
    martinemde committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5599466 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Update app/models/events/rubygem_event.rb 

    Co-authored-by: Martin Emde <[email protected]>
    @colby-swandale @martinemde
    colby-swandale and martinemde committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    764b75c View commit details
    Browse the repository at this point in the history