Use hook relay for web_hooks/fire action #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5011 +/- ##
==========================================
+ Coverage 97.02% 97.03% +0.01%
==========================================
Files 420 421 +1
Lines 8726 8775 +49
==========================================
+ Hits 8466 8515 +49
Misses 260 260 ☔ View full report in Codecov by Sentry. |
segiddins
force-pushed
the
segiddins/use-hook-relay-for-web_hooks-fire-action
branch
from
0b669af
to
82847bf
Compare
segiddins
force-pushed
the
segiddins/use-hook-relay-for-web_hooks-fire-action
branch
from
82847bf
to
e6be671
Compare
martinemde
reviewed
Sep 24, 2024
| deadline = (Rails.env.test? ? 0.01 : 10).seconds.from_now | ||
| response = nil | ||
| until Time.zone.now > deadline | ||
| sleep 0.5 |
There was a problem hiding this comment.
This seems like it could introduce a hung worker for up to 10 seconds for each job. Is there concern that this could be abused and cause delays on other queues?
There was a problem hiding this comment.
it will only be hit on the fire endpoint, and that was already a synchronous call to an arbitrary URL, so I think this is roughly equivalent
martinemde
approved these changes
Sep 24, 2024
segiddins
deleted the
segiddins/use-hook-relay-for-web_hooks-fire-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TOB-RGM-8