Convert data dumps page to stimulus.js #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
martinemde/data-dump-stimulus
branch
from
3b53c10
to
0ce7b9e
Compare
martinemde
commented
Sep 28, 2024
app/views/pages/data.html.erb
Outdated
| <template data-dump-target="template"> | ||
| <li><a href="#"></a></li> | ||
| </template> | ||
| </ul> | ||
| <p>We also provide weekly dumps of the historial RubyGems.org Redis data. (We do not use redis anymore but these are here for historical purposes.)</p> |
There was a problem hiding this comment.
The latest redis dump is 2016. Can we drop it from the page?
There was a problem hiding this comment.
I'll remove it. I can't see a reason why we'd need 8 year old redis backups.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5080 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 421 421
Lines 8776 8776
=======================================
Hits 8516 8516
Misses 260 260 ☔ View full report in Codecov by Sentry. |
segiddins
approved these changes
Sep 28, 2024
martinemde
force-pushed
the
martinemde/data-dump-stimulus
branch
from
0ce7b9e
to
e235c1c
Compare
martinemde
force-pushed
the
martinemde/data-dump-stimulus
branch
from
e235c1c
to
c28e3c8
Compare
martinemde
force-pushed
the
martinemde/data-dump-stimulus
branch
from
ec723f1
to
d7f7059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm targeting the static pages for the first to receive the new design.
The data dump page uses javascript to fill the available dumps. Without a template based approach, it's difficult to switch to Tailwind. Rather than fuss with the original javascript, I quickly rewrote the page using stimulus controllers. It otherwise looks identical.