Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update pulsar endpoint to use 127.0.0.1 #705

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore: update pulsar endpoint to use 127.0.0.1 #705

merged 1 commit into from
Jan 6, 2025

Conversation

mihir20
Copy link
Contributor

@mihir20 mihir20 commented Jan 3, 2025

Description

Use loopback address as host address as localhost is not reachable.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@mihir20 mihir20 marked this pull request as ready for review January 3, 2025 09:47
fracasula
fracasula approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you tried this locally, in src-router, ingestion-svc and rudder-server, I don't see a problem with the change 👍

@mihir20 mihir20 merged commit e469555 into main Jan 6, 2025
16 checks passed
@mihir20 mihir20 deleted the mihir/fix-pulsar-url branch January 6, 2025 10:12
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktgowtham ktgowtham ktgowtham approved these changes

@fracasula fracasula fracasula approved these changes

@BonapartePC BonapartePC Awaiting requested review from BonapartePC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihir20 @fracasula @ktgowtham