Skip to content

Commit

Permalink
fix: kafka topic name regex (#1698)
Browse files Browse the repository at this point in the history
  • Loading branch information
achettyiitr authored Sep 20, 2024
1 parent 860a9bb commit 3583ce8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/configurations/destinations/kafka/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"label": "Topic Name",
"note": "Please enter the topic name",
"configKey": "topic",
"regex": "^[a-zA-Z0-9_\\-]{1,249}$",
"regex": "^[a-zA-Z0-9_.\\-]{1,249}$",
"regexErrorMessage": "Invalid Topic Name",
"placeholder": "e.g: test-topic"
}
Expand Down
8 changes: 8 additions & 0 deletions test/data/validation/destinations/kafka.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@
},
"result": true
},
{
"config": {
"hostName": "rudder.com",
"port": "65535",
"topic": "test.Topic-1_2_3"
},
"result": true
},
{
"config": {
"hostName": "rudder.com",
Expand Down

0 comments on commit 3583ce8

Please sign in to comment.