chore: add commands for lint:fix, lint & update lint command to use f…

…ormat && lint:fix, apply prettier changes

Signed-off-by: Sai Sankeerth <[email protected]>

.eslintrc.json

@@ -13,7 +13,7 @@
     "plugin:@typescript-eslint/recommended",
     "prettier"
   ],
-  "plugins": ["@typescript-eslint", "unicorn", "prettier"],
+  "plugins": ["@typescript-eslint", "unicorn"],
   "globals": {},
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
@@ -65,7 +65,6 @@
     "sonarjs/no-identical-functions": "error",
     "no-prototype-builtins": "off",
     "@typescript-eslint/dot-notation": "error",
-    "@typescript-eslint/no-unused-vars": "error",
-    "prettier/prettier": "error"
+    "@typescript-eslint/no-unused-vars": "error"
   }
 }

.github/workflows/build-push-docker-image.yml

@@ -155,7 +155,7 @@ jobs:
         if: ${{ inputs.build_type == 'dt' }}
         run: |
           docker buildx imagetools create -t rudderstack/rudder-transformer:latest ${{ inputs.push_tags }}-amd64 ${{ inputs.push_tags }}-arm64
-      
+
       - name: Create latest ut multi-arch manifest
         # To be triggered only for release/hotfix PR merges coming from `prepare-for-prod-ut-deploy.yaml`
         if: ${{ inputs.build_type == 'ut' }}

.github/workflows/prepare-for-staging-deploy.yml

@@ -68,7 +68,6 @@ jobs:
     secrets:
       DOCKERHUB_PROD_TOKEN: ${{ secrets.DOCKERHUB_PROD_TOKEN }}
 
-
   create-pull-request:
     name: Update Helm Charts For Staging and Create Pull Request
     runs-on: ubuntu-latest

.github/workflows/verify.yml

@@ -23,13 +23,14 @@ jobs:
 
       - name: Install Dependencies
         run: npm ci
-      
+
       - name: Run Lint Checks
         run: |
           npm run lint
-      
+
       - run: git diff --exit-code
-      
+
       - name: Error message
         if: ${{ failure() }}
-        run: echo 'Eslint check is failing Ensure you have run `npm run lint || npx eslint --fix . || npx eslint --fix <FILE_PATH>` and committed the files locally.'
+        run: |
+          echo 'Eslint check is failing Ensure you have run `npm run lint` and committed the files locally.'

.prettierignore

@@ -7,3 +7,4 @@ test/**/*.js
 !test/**/data.js
 src/util/lodash-es-core.js
 src/util/url-search-params.min.js
+dist

jest.default.config.js

@@ -27,7 +27,7 @@ module.exports = {
   coverageDirectory: 'reports/coverage',
 
   // An array of regexp pattern strings used to skip coverage collection
-  coveragePathIgnorePatterns: ['/node_modules/', '__tests__', 'warehouse/v0' ,'test'],
+  coveragePathIgnorePatterns: ['/node_modules/', '__tests__', 'warehouse/v0', 'test'],
 
   // A list of reporter names that Jest uses when writing coverage reports
   coverageReporters: ['json', 'text', 'lcov', 'clover'],

package.json

@@ -19,9 +19,9 @@
     "setup": "npm ci",
     "setup:swagger": "swagger-cli bundle swagger/api.yaml --outfile dist/swagger.json --type json",
     "format": "prettier --write .",
-    "lint": "eslint . || exit 0",
     "lint:fix": "eslint . --fix",
     "lint:fix:json": "eslint --ext .json --fix .",
+    "lint": "npm run format && npm run lint:fix",
     "check:merge": "npm run verify || exit 1; codecov",
     "start": "cd dist;node ./src/index.js;cd ..",
     "build:start": "npm run build && npm run start",

src/adapters/networkHandlerFactory.js

@@ -27,9 +27,8 @@ SUPPORTED_VERSIONS.forEach((version) => {
       //   },
       // generic: GenericNetworkHandler,
       // }
-      handlers[version][dest] = require(
-        `../${version}/destinations/${dest}/networkHandler`,
-      ).networkHandler;
+      handlers[version][dest] =
+        require(`../${version}/destinations/${dest}/networkHandler`).networkHandler;
     } catch {
       // Do nothing as exception indicates
       // network handler is not defined for that destination

src/cdk/v2/destinations/bingads_audience/procWorkflow.yaml

@@ -50,4 +50,4 @@ steps:
         const response = $.defaultRequestConfig();
         response.body.JSON = payload;
         response
-      )
+      )

src/cdk/v2/destinations/fullstory/procWorkflow.yaml

@@ -5,7 +5,7 @@ bindings:
     exportAll: true
   - name: removeUndefinedAndNullValues
     path: ../../../../v0/util
-  
+
 steps:
   - name: validateInput
     template: |
@@ -28,7 +28,7 @@ steps:
       $.context.payload.uid = .message.userId;
       $.context.payload.email = .message.context.traits.email;
       $.context.payload.display_name = .message.context.traits.name;
-  
+
   - name: trackPayload
     condition: $.context.messageType == "track"
     template: |
@@ -42,9 +42,9 @@ steps:
     condition: $.context.messageType == "track"
     template: |
       $.assert(.message.event, "event is required for track call")
-  
+
   - name: mapContextFieldsForTrack
-    condition: $.context.messageType == "track" 
+    condition: $.context.messageType == "track"
     template: |
       $.context.payload.context.browser = {
         "url": .message.context.page.url,
@@ -67,7 +67,7 @@ steps:
         "region": .message.properties.region,
         "country": .message.properties.country,
       };
-  
+
   - name: mapIdsForTrack
     condition: $.context.messageType == "track"
     template: |
@@ -99,6 +99,3 @@ steps:
          "params": {},
          "files": {}
        })
-
-
-  

src/cdk/v2/destinations/gladly/procWorkflow.yaml

@@ -13,7 +13,6 @@ bindings:
     path: ../../../../adapters/network
   - name: processAxiosResponse
     path: ../../../../adapters/utils/networkUtils
-
 
 steps:
   - name: checkIfProcessed

src/cdk/v2/destinations/gladly/rtWorkflow.yaml

@@ -30,4 +30,4 @@ steps:
       )[]
   - name: finalPayload
     template: |
-      [...$.outputs.successfulEvents, ...$.outputs.failedEvents]
+      [...$.outputs.successfulEvents, ...$.outputs.failedEvents]

src/cdk/v2/destinations/heap/procWorkflow.yaml

@@ -58,5 +58,3 @@ steps:
           "Content-Type": "application/json"
         };
         response
-
-        

src/cdk/v2/destinations/kochava/procWorkflow.yaml

@@ -10,7 +10,6 @@ bindings:
   - path: ../../bindings/jsontemplate
   - path: ./config.js
 
-
 steps:
   - name: validateInput
     template: |

src/cdk/v2/destinations/lytics/procWorkflow.yaml

@@ -45,7 +45,7 @@ steps:
       $.context.payload._e = .message.event;
   - name: pageOrScreenPayload
     condition: $.context.messageType === {{$.EventType.PAGE}} ||
-               $.context.messageType === {{$.EventType.SCREEN}}
+      $.context.messageType === {{$.EventType.SCREEN}}
     template: |
       $.context.payload.event = .message.name
   - name: cleanPaylod
@@ -66,4 +66,3 @@ steps:
           "Content-Type": "application/json"
         };
         response
-

src/cdk/v2/destinations/pinterest_tag/procWorkflow.yaml

@@ -246,4 +246,4 @@ steps:
           },
           "params": $.outputs.checkSendTestEventConfig,
           "files": {}
-        })[]
+        })[]

src/cdk/v2/destinations/pinterest_tag/rtWorkflow.yaml

@@ -12,7 +12,7 @@ steps:
       If sendTestEvent is enabled, we send test event to the destination
       ref: https://help.pinterest.com/en/business/article/track-conversions-with-the-conversions-api
     template: |
-        ^[0].destination.Config.sendAsTestEvent ? {"test": true} : {}
+      ^[0].destination.Config.sendAsTestEvent ? {"test": true} : {}
 
   - name: transform
     externalWorkflow:

src/cdk/v2/destinations/sprig/procWorkflow.yaml

@@ -69,5 +69,3 @@ steps:
         "authorization": "API-Key " + .destination.Config.apiKey
       };
       response
-
-  

src/cdk/v2/destinations/statsig/procWorkflow.yaml

@@ -26,4 +26,3 @@ steps:
             "content-type": "application/json"
         };
         response
-

src/cdk/v2/destinations/tiktok_audience/procWorkflow.yaml

@@ -1,4 +1,3 @@
-
 bindings:
   - name: EventType
     path: ../../../../constants
@@ -48,7 +47,6 @@ steps:
         "action": $.ACTION_MAP[action],
       })[]
 
-
   - name: buildResponseForProcessTransformation
     description: build response
     template: |

src/cdk/v2/destinations/zapier/procWorkflow.yaml

@@ -44,4 +44,3 @@ steps:
           "content-type": "application/json"
         };
         response
-

src/controllers/util/index.ts

@@ -51,7 +51,7 @@ export class ControllerUtility {
 
   private static convertSourceInputv0Tov1(sourceEvents: unknown[]): SourceInput[] {
     return sourceEvents.map(
-      (sourceEvent) => ({ event: sourceEvent, source: undefined }) as SourceInput,
+      (sourceEvent) => ({ event: sourceEvent, source: undefined } as SourceInput),
     );
   }
 

src/services/destination/nativeIntegration.ts

@@ -214,7 +214,7 @@ export class NativeIntegrationDestinationService implements DestinationService {
               error: JSON.stringify(v0Response.destinationResponse?.response),
               statusCode: v0Response.status,
               metadata,
-            }) as DeliveryJobState,
+            } as DeliveryJobState),
         );
         responseProxy = {
           response: jobStates,

src/services/userTransform.ts

@@ -158,7 +158,7 @@ export class UserTransformService {
                   statusCode: status,
                   metadata: e.metadata,
                   error: errorString,
-                }) as ProcessorTransformationResponse,
+                } as ProcessorTransformationResponse),
             ),
           );
           stats.counter('user_transform_errors', eventsToProcess.length, {

src/util/customTransformer-v1.js

@@ -55,7 +55,7 @@ async function userTransformHandlerV1(
   testMode = false,
 ) {
   if (!userTransformation.versionId) {
-    return { transformedEvents : events };
+    return { transformedEvents: events };
   }
 
   const isolatevmFactory = await getFactory(
@@ -88,9 +88,9 @@ async function userTransformHandlerV1(
     const tags = {
       identifier: 'v1',
       errored: transformationError ? true : false,
-      ...events.length && events[0].metadata ? getMetadata(events[0].metadata) : {},
-      ...events.length && events[0].metadata ? getTransformationMetadata(events[0].metadata) : {}
-    }
+      ...(events.length && events[0].metadata ? getMetadata(events[0].metadata) : {}),
+      ...(events.length && events[0].metadata ? getTransformationMetadata(events[0].metadata) : {}),
+    };
     stats.counter('user_transform_function_input_events', events.length, tags);
     stats.timing('user_transform_function_latency', invokeTime, tags);
   }

src/util/customTransformer.js

@@ -254,9 +254,9 @@ async function runUserTransform(
     const tags = {
       identifier: 'v0',
       errored: transformationError ? true : false,
-      ...events.length && events[0].metadata ? getMetadata(events[0].metadata) : {},
-      ...events.length && events[0].metadata ? getTransformationMetadata(events[0].metadata) : {}
-    }
+      ...(events.length && events[0].metadata ? getMetadata(events[0].metadata) : {}),
+      ...(events.length && events[0].metadata ? getTransformationMetadata(events[0].metadata) : {}),
+    };
 
     stats.counter('user_transform_function_input_events', events.length, tags);
     stats.timing('user_transform_function_latency', invokeTime, tags);

src/util/customTransformerFactory.js

@@ -1,12 +1,6 @@
-const { 
-  setOpenFaasUserTransform,
-  runOpenFaasUserTransform,
-} = require('./customTransformer-faas');
+const { setOpenFaasUserTransform, runOpenFaasUserTransform } = require('./customTransformer-faas');
 
-const {
-  userTransformHandlerV1,
-  setUserTransformHandlerV1,
-} = require('./customTransformer-v1');
+const { userTransformHandlerV1, setUserTransformHandlerV1 } = require('./customTransformer-v1');
 
 const UserTransformHandlerFactory = (userTransformation) => {
   return {
@@ -23,20 +17,10 @@ const UserTransformHandlerFactory = (userTransformation) => {
       switch (userTransformation.language) {
         case 'pythonfaas':
         case 'python':
-          return runOpenFaasUserTransform(
-            events,
-            userTransformation,
-            libraryVersionIds,
-            testMode
-          );
+          return runOpenFaasUserTransform(events, userTransformation, libraryVersionIds, testMode);
 
         default:
-          return userTransformHandlerV1(
-            events,
-            userTransformation,
-            libraryVersionIds,
-            testMode
-          );
+          return userTransformHandlerV1(events, userTransformation, libraryVersionIds, testMode);
       }
     },
   };

src/util/ivmFactory.js

@@ -23,7 +23,9 @@ async function evaluateModule(isolate, context, moduleCode) {
 }
 
 async function loadModule(isolateInternal, contextInternal, moduleName, moduleCode) {
-  const module = await isolateInternal.compileModule(moduleCode, { filename: `library ${moduleName}` });
+  const module = await isolateInternal.compileModule(moduleCode, {
+    filename: `library ${moduleName}`,
+  });
   await module.instantiate(contextInternal, () => {});
   return module;
 }
@@ -256,7 +258,7 @@ async function createIvm(code, libraryVersionIds, versionId, secrets, testMode)
     }
   });
 
-  await jail.set('extractStackTrace', function(trace, stringLiterals) {
+  await jail.set('extractStackTrace', function (trace, stringLiterals) {
     return extractStackTraceUptoLastSubstringMatch(trace, stringLiterals);
   });
 
@@ -346,7 +348,9 @@ async function createIvm(code, libraryVersionIds, versionId, secrets, testMode)
   // Now we can execute the script we just compiled:
   const bootstrapScriptResult = await bootstrap.run(context);
   // const customScript = await isolate.compileScript(`${library} ;\n; ${code}`);
-  const customScriptModule = await isolate.compileModule(`${codeWithWrapper}`, { filename: 'base transformation' });
+  const customScriptModule = await isolate.compileModule(`${codeWithWrapper}`, {
+    filename: 'base transformation',
+  });
   await customScriptModule.instantiate(context, async (spec) => {
     if (librariesMap[spec]) {
       return compiledModules[spec].module;

src/v0/destinations/adobe_analytics/utils.js

@@ -93,7 +93,7 @@ function escapeToHTML(inputString) {
         '&': '&',
         '<': '&lt;',
         '>': '&gt;',
-      })[match],
+      }[match]),
   );
 }