fix: marketo backward compatibility (#2880)

rudderlabs · Dec 6, 2023 · af6aebb · af6aebb
2 parents 45db590 + 24a2cd4
commit af6aebb
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 32 deletions.
diff --git a/src/services/destination/postTransformation.ts b/src/services/destination/postTransformation.ts
@@ -16,15 +16,6 @@ import { ErrorReportingService } from '../errorReporting';
 import tags from '../../v0/util/tags';
 import stats from '../../util/stats';
 
-type ErrorResponse = {
-  status?: number;
-  message?: string;
-  destinationResponse?: object;
-  statTags?: object;
-  authErrorCategory?: string | undefined;
-  response?: object | undefined;
-};
-
 export class DestinationPostTransformationService {
   public static handleProcessorTransformSucessEvents(
     event: ProcessorTransformationRequest,
@@ -148,7 +139,7 @@ export class DestinationPostTransformationService {
   }
 
   public static handleDeliveryFailureEvents(
-    error: ErrorResponse,
+    error: NonNullable<unknown>,
     metaTo: MetaTransferObject,
   ): DeliveryResponse {
     const errObj = generateErrorObject(error, metaTo.errorDetails, false);
@@ -161,12 +152,6 @@ export class DestinationPostTransformationService {
         authErrorCategory: errObj.authErrorCategory,
       }),
     } as DeliveryResponse;
-
-    // for transformer-proxy to maintain contract
-    const { response } = error;
-    if (response) {
-      resp.response = response;
-    }
     ErrorReportingService.reportError(error, metaTo.errorContext, resp);
     return resp;
   }

diff --git a/src/v0/destinations/marketo/config.js b/src/v0/destinations/marketo/config.js
@@ -14,24 +14,18 @@ const DESTINATION = 'marketo';
 const formatConfig = (destination) => ({
   ID: destination.ID,
   ...destination.Config,
-  customActivityEventMap: getHashFromArray(
-    destination.Config.rudderEventsMapping,
-    'event',
-    'marketoActivityId',
-    false,
-  ),
+  customActivityEventMap: destination.Config?.rudderEventsMapping
+    ? getHashFromArray(destination.Config.rudderEventsMapping, 'event', 'marketoActivityId', false)
+    : getHashFromArray(destination.Config.customActivityEventMap, 'from', 'to', false),
   customActivityPropertyMap: getHashFromArray(
     destination.Config.customActivityPropertyMap,
     'from',
     'to',
     false,
   ),
-  customActivityPrimaryKeyMap: getHashFromArray(
-    destination.Config.rudderEventsMapping,
-    'event',
-    'marketoPrimarykey',
-    false,
-  ),
+  customActivityPrimaryKeyMap: destination.Config?.rudderEventsMapping
+    ? getHashFromArray(destination.Config.rudderEventsMapping, 'event', 'marketoPrimarykey', false)
+    : getHashFromArray(destination.Config.customActivityPrimaryKeyMap, 'from', 'to', false),
   leadTraitMapping: getHashFromArray(destination.Config.leadTraitMapping, 'from', 'to', false),
   responseRules: destination.DestinationDefinition
     ? destination.DestinationDefinition.ResponseRules

diff --git a/test/__tests__/data/marketo_input.json b/test/__tests__/data/marketo_input.json
@@ -170,11 +170,16 @@
           }
         ],
         "createIfNotExist": true,
-        "rudderEventsMapping": [
+        "customActivityPrimaryKeyMap": [
           {
-            "event": "Product Clicked",
-            "marketoPrimarykey": "name",
-            "marketoActivityId": "100001"
+            "from": "Product Clicked",
+            "to": "name"
+          }
+        ],
+        "customActivityEventMap": [
+          {
+            "from": "Product Clicked",
+            "to": "100001"
           }
         ]
       }