chore: remove value from updation webhook events

rudderlabs · Dec 25, 2024 · b48828f · b48828f
1 parent 2bfb88c
commit b48828f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/v1/sources/shopify/webhookTransformations/serverSideTransform.js b/src/v1/sources/shopify/webhookTransformations/serverSideTransform.js
@@ -46,7 +46,7 @@ const ecomPayloadBuilder = (event, shopifyTopic) => {
   message.setEventType(EventType.TRACK);
   message.setEventName(RUDDER_ECOM_MAP[shopifyTopic]);
 
-  const properties = createPropertiesForEcomEventFromWebhook(event);
+  const properties = createPropertiesForEcomEventFromWebhook(event, shopifyTopic);
   message.properties = removeUndefinedAndNullValues(properties);
   // Map Customer details if present
   const customerDetails = get(event, 'customer');

diff --git a/src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js b/src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
@@ -25,12 +25,15 @@ const getProductsFromLineItems = (lineItems, mapping) => {
  * @param {Object} message
  * @returns {Object} properties
  */
-const createPropertiesForEcomEventFromWebhook = (message) => {
+const createPropertiesForEcomEventFromWebhook = (message, shopifyTopic) => {
   const { line_items: lineItems } = message;
   if (!lineItems || lineItems.length === 0) {
     return [];
   }
   const mappedPayload = constructPayload(message, productMappingJSON);
+  if (shopifyTopic === 'orders_updated' || shopifyTopic === 'checkouts_update') {
+    delete mappedPayload.value;
+  }
   mappedPayload.products = getProductsFromLineItems(lineItems, lineItemsMappingJSON);
   return mappedPayload;
 };

diff --git a/test/integrations/sources/shopify/webhookTestScenarios/CheckoutEventsTests.ts b/test/integrations/sources/shopify/webhookTestScenarios/CheckoutEventsTests.ts
@@ -543,7 +543,6 @@ export const checkoutEventsTestScenarios = [
                       },
                     ],
                     tax: 0,
-                    value: '736.85',
                   },
                   timestamp: '2024-09-17T07:29:02.000Z',
                   traits: {
@@ -1208,7 +1207,6 @@ export const checkoutEventsTestScenarios = [
                   event: 'Order Updated',
                   properties: {
                     order_id: '5778367414385',
-                    value: '600.00',
                     tax: 0,
                     currency: 'USD',
                     products: [