fix: update for supporting disallowed events

rudderlabs · Dec 12, 2024 · d00f31f · d00f31f
1 parent a5ba58c
commit d00f31f
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 4 deletions.
diff --git a/src/v0/destinations/iterable/util.js b/src/v0/destinations/iterable/util.js
@@ -803,11 +803,13 @@ const checkIfEventIsAbortableAndExtractErrorMessage = (event, destinationRespons
     ITERABLE_RESPONSE_EMAIL_PATHS.find((emailPath) =>
       isValueInResponseArray(emailPath, eventValues.email, destinationResponse.response),
     ) ||
-    isValueInResponseArray(
+    (isValueInResponseArray(
       'disallowedEventNames',
       eventValues.eventName,
       destinationResponse.response,
-    );
+    )
+      ? 'disallowedEventNames'
+      : null);
 
   if (matchingPath) {
     const responseValueArray = getValueFromResponse(matchingPath, destinationResponse.response);
@@ -818,7 +820,7 @@ const checkIfEventIsAbortableAndExtractErrorMessage = (event, destinationRespons
       if (ITERABLE_RESPONSE_USER_ID_PATHS.some((userIdPath) => matchingPath.includes(userIdPath))) {
         return value === eventValues.userId;
       }
-      if (matchingPath.includes('disallowedEventNames')) {
+      if (matchingPath === 'disallowedEventNames') {
         return value === eventValues.eventName;
       }
       return false;

diff --git a/src/v0/destinations/iterable/util.test.js b/src/v0/destinations/iterable/util.test.js
@@ -864,7 +864,7 @@ describe('iterable utils test', () => {
 
     // Returns appropriate error message for abortable event
 
-    it('should find the right value for which it should fail and passes otherwise', () => {
+    it('should find the right value for which it should fail and passes otherwise for emails', () => {
       const event = {
         email: 'test',
         userId: 'user123',
@@ -905,5 +905,51 @@ describe('iterable utils test', () => {
       expect(result.isAbortable).toBe(false);
       expect(result.errorMsg).toBe('');
     });
+
+    it('should find the right value for which it should fail and passes otherwise for userIds', () => {
+      const event = {
+        email: 'test',
+        userId: 'user123',
+        eventName: 'purchase',
+        dataFields: { customField1: 'value1', customField2: 'value2' },
+      };
+      const destinationResponse = {
+        response: {
+          failCount: 1,
+          failedUpdates: {
+            invalidUserIds: ['user123'],
+          },
+        },
+      };
+      const result = checkIfEventIsAbortableAndExtractErrorMessage(event, destinationResponse);
+      expect(result).toEqual({
+        isAbortable: true,
+        errorMsg:
+          'Request failed for value "user123" because it is "failedUpdates.invalidUserIds".',
+      });
+    });
+
+    it('should find the right value for which it should fail and passes otherwise for disallowed events', () => {
+      const event = {
+        email: 'test',
+        userId: 'user123',
+        eventName: 'purchase',
+        dataFields: { customField1: 'value1', customField2: 'value2' },
+      };
+      const destinationResponse = {
+        response: {
+          failCount: 1,
+          disallowedEventNames: ['purchase'],
+          failedUpdates: {
+            invalidUserIds: [],
+          },
+        },
+      };
+      const result = checkIfEventIsAbortableAndExtractErrorMessage(event, destinationResponse);
+      expect(result).toEqual({
+        isAbortable: true,
+        errorMsg: 'Request failed for value "purchase" because it is "disallowedEventNames".',
+      });
+    });
   });
 });