-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fb pixel test case refactor #3075
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3075/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3075 +/- ##
===========================================
+ Coverage 84.86% 87.62% +2.76%
===========================================
Files 497 548 +51
Lines 27412 29558 +2146
Branches 6597 7045 +448
===========================================
+ Hits 23262 25899 +2637
+ Misses 3694 3348 -346
+ Partials 456 311 -145 ☔ View full report in Codecov by Sentry. |
test/integrations/destinations/facebook_pixel/processor/data1.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/configLevelFeaturesTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/configLevelFeaturesTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/configLevelFeaturesTestData.ts
Outdated
Show resolved
Hide resolved
Please add what are scenarios that you were able to add on the existing tests cases, the number of new scenarios added |
test/integrations/destinations/facebook_pixel/processor/configLevelFeaturesTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/ecommTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/ecommTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
Outdated
Show resolved
Hide resolved
Also in terms of coverage whats the coverage diff btw old test cases and new ones |
test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-1472
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.