Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version deprecation failure false positive #3104

Merged
merged 11 commits into from
Feb 28, 2024
Merged

fix: version deprecation failure false positive #3104

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bb9da58
fix: version deprecation failure false positive in gainsight_px
Feb 19, 2024
1f05d50
Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…
Feb 19, 2024
6a7580c
chore: move test-case data to constant
Feb 22, 2024
b265f9b
chore: trim extra data in test-cases
Feb 26, 2024
9dfab95
chore: trim extra data in destination configuration for test-cases
Feb 26, 2024
c13a72e
Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…
Feb 26, 2024
4a7eb95
Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…
Feb 26, 2024
6384d58
Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…
Feb 26, 2024
380a2e2
Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…
Feb 27, 2024
8293e2b
Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…
Feb 28, 2024
309c7bc
chore: formatting updates
Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/v0/destinations/gainsight_px/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ const { getDynamicErrorType } = require('../../../adapters/utils/networkUtils');
const { JSON_MIME_TYPE } = require('../../util/constant');

const handleErrorResponse = (error, customErrMessage, expectedErrStatus, defaultStatus = 400) => {
let destResp;
let errMessage = '';
let errorStatus = defaultStatus;

if (error.response && error.response.data) {
errMessage = error.response.data.externalapierror
? JSON.stringify(error.response.data.externalapierror)
: JSON.stringify(error.response.data);
destResp = error.response?.data?.externalapierror ?? error.response?.data;
errMessage = JSON.stringify(destResp);

errorStatus = error.response.status;

Expand All @@ -26,7 +26,7 @@ const handleErrorResponse = (error, customErrMessage, expectedErrStatus, default
{
[tags.TAG_NAMES.ERROR_TYPE]: getDynamicErrorType(errorStatus),
},
error,
destResp,
);
};

Expand Down
Loading
Loading