Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics for mailjet #3917

Merged
merged 3 commits into from
Dec 6, 2024
Merged

chore: add metrics for mailjet #3917

merged 3 commits into from
Dec 6, 2024

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Dec 6, 2024

What are the changes introduced in this PR?

Currently we have no observability for how much data is being batched for mailjet hence we are adding metrics for the same.

@utsabc utsabc requested review from a team as code owners December 6, 2024 07:08
@utsabc utsabc requested review from koladilip and ItsSudip December 6, 2024 07:08
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (b3f7140) to head (4b61508).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3917   +/-   ##
========================================
  Coverage    90.47%   90.47%           
========================================
  Files          615      615           
  Lines        32329    32331    +2     
  Branches      7682     7680    -2     
========================================
+ Hits         29250    29252    +2     
- Misses        2823     2855   +32     
+ Partials       256      224   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@utsabc utsabc merged commit f44f148 into develop Dec 6, 2024
25 of 27 checks passed
@utsabc utsabc deleted the chore.add-metrics-mailjet branch December 6, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants