Addressed review comments

rudyflores · Nov 17, 2021 · 5d950c5 · 5d950c5
1 parent c8c5a6d
commit 5d950c5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/packages/monaco/src/browser/monaco-quick-input-service.ts b/packages/monaco/src/browser/monaco-quick-input-service.ts
@@ -261,7 +261,7 @@ export class MonacoQuickInputService implements QuickInputService {
                                     if (index !== -1) {
                                         const filteredItems = wrapped.items.slice();
                                         const removed = filteredItems.splice(index, 1);
-                                        const activeFilteredItems = wrapped.activeItems.filter(ai => ai !== removed[0]);
+                                        const activeFilteredItems = wrapped.activeItems.filter(item => item !== removed[0]);
                                         wrapped.items = filteredItems;
                                         if (activeFilteredItems) {
                                             wrapped.activeItems = activeFilteredItems;

diff --git a/packages/workspace/src/browser/quick-open-workspace.ts b/packages/workspace/src/browser/quick-open-workspace.ts
@@ -53,11 +53,6 @@ export class QuickOpenWorkspace {
         ]);
         const home = new URI(homeDirUri).path.toString();
         await this.preferences.ready;
-        if (!workspaces.length) {
-            this.items.push({
-                label: nls.localize('theia/windowActions/noRecentWorkSpaces', 'No Recent Workspaces')
-            });
-        }
         this.items.push({
             type: 'separator',
             label: nls.localizeByDefault('folders & workspaces')
@@ -95,7 +90,7 @@ export class QuickOpenWorkspace {
         }
         this.quickInputService?.showQuickPick(this.items, {
             placeholder: nls.localize(
-                'theia/windowActions/openRecentPlaceholder',
+                'vscode/windowActions/openRecentPlaceholder',
                 'Type the name of the workspace you want to open'),
             onDidTriggerItemButton: async context => {
                 const resource = context.item.resource;

diff --git a/packages/workspace/src/node/default-workspace-server.ts b/packages/workspace/src/node/default-workspace-server.ts
@@ -102,10 +102,10 @@ export class DefaultWorkspaceServer implements WorkspaceServer {
         const index = recentRoots.indexOf(uri);
         if (index !== -1) {
             recentRoots.splice(index, 1);
+            this.writeToUserHome({
+                recentRoots
+            });
         }
-        this.writeToUserHome({
-            recentRoots
-        });
     }
 
     async getRecentWorkspaces(): Promise<string[]> {