desktop: Fix filesystem access dialog #18147
Merged
+81
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-desktop
torokati44
approved these changes
Oct 2, 2024
This patch fixes the following two issues: 1. On Windows the allowed path check was not always working, due to Windows paths being Windows paths, now paths are canonicalized before comparison. 2. On some systems the dialog was not rendered when the main SWF wasn't loaded, and the dialog was not able to allow the main SWF. Now the dialog allows the SWF instantly when constructed.
adrian17
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the following two issues:
On Windows the allowed path check was not always working, due to Windows paths being Windows paths, now paths are canonicalized before comparison.
On some systems the dialog was not rendered when the main SWF wasn't loaded, and the dialog was not able to allow the main SWF. Now the dialog allows the SWF instantly when constructed.
That needs testing from @n0samu and @Lord-McSweeney, as I cannot reproduce these issues.
Fixes #18141, fixes #18142.