extension: Set responseHeadersUnsupported to false explicitly #18176
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
commented
Oct 5, 2024
| @@ -156,6 +157,7 @@ async function disableSWFTakeover() { | |||
| await utils.declarativeNetRequest.updateDynamicRules({ | |||
| removeRuleIds: [1, 2, 3], | |||
| }); | |||
| utils.storage.sync.set({ responseHeadersUnsupported: false }); | |||
There was a problem hiding this comment.
I don't need this redundancy to be honest, but it's probably fine. Willing to hear other opinions though.
Honestly, I think disableSWFTakeover can run unconditionally and set nothing. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/updateDynamicRules#removeruleids says any invalid IDs are ignored.
n0samu
approved these changes
Oct 5, 2024
danielhjacobs
added
A-web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the cause of the issue described here: #18161 (reply in thread)
I mentioned this briefly on Discord: When you use Ruffle on a browser without support for a responseHeaders RuleCondition that later gets support, Ruffle has already set this value to true. I assumed that we could just default to false if it wasn't set and that would be fine, but then in this situation it just stays true indefinitely.