Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Migrate to winit 0.30's ApplicationHandler #18193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dinnerbone
Copy link
Contributor

This is one of the TODOs from #17401

Needs testing please! Largest change is to ControlFlow (specifically, how often we redraw things). In the previous update model, we'd force it to wait until the next frame time after every event we receive. Now, we conditionally do it at the end of a batch of events.

There's still another pending TODO (make the window later, instead of before event loop) - but that's a larger and messier change.
We can also clean up the ControlFlow usage further by using a callback in egui, but I didn't want to risk more changes than needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant