Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bytes processor #2008

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Add bytes processor #2008

merged 3 commits into from
Oct 29, 2021

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Oct 28, 2021

See #1812

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one nit.


namespace Elastica\Processor;

class BytesProcessor extends AbstractProcessor
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it, nice catch ;)

@deguif deguif merged commit 9bdb007 into ruflin:master Oct 29, 2021
@deguif deguif self-assigned this Dec 7, 2021
@deguif deguif mentioned this pull request Dec 9, 2021
15 tasks
@deguif deguif deleted the bytes-processor branch December 9, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants