Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conflict with some guzzle versions #2066

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from
Open

Add conflict with some guzzle versions #2066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
278ce0d
Stop suggesting egeloen/http-adapter
franmomu May 20, 2022
98033f4
Add conflict with guzzle versions
franmomu May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
"symfony/deprecation-contracts": "^2.2 || ^3.0",
"symfony/polyfill-php73": "^1.19"
},
"conflict": {
"guzzlehttp/guzzle": "<6.3 || >=7.0,<7.2"
},
"require-dev": {
"aws/aws-sdk-php": "^3.155",
"guzzlehttp/guzzle": "^6.3 || ^7.2",
Expand All @@ -31,7 +34,6 @@
},
"suggest": {
"aws/aws-sdk-php": "Allow using IAM authentication with Amazon ElasticSearch Service",
"egeloen/http-adapter": "Allow using httpadapter as transport",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I did it in a separated commit 278ce0d (the project is abandoned), but it could be done in another PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deprecated in #1940 so stopping to suggest it is a logical move I think

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal SGTM, can we move it to a separate PR? Sounds like it is not related to the guzzle discussion.

"guzzlehttp/guzzle": "Allow using guzzle as transport",
"monolog/monolog": "Logging request"
},
Expand Down