Drop ES 7 from the pipeline #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we keep the test for 7.x around until we actually break it? For migration purpose, it is kind of nice to know Elastica still works with 7.last. I suggest to add a line to the code you removed and the testing, that this is here because of backward compatibility but not officially supported. As soon as we hit a change where there is extra work to keep compatibility, we remove the code. On the docs, we should always state that it is not officially supported. |
|
Fine with me @ruflin. I'll amend PR later today |
sidz
force-pushed
the
drop-testing-against-es-7
branch
from
1290818
to
5f38f50
Compare
ruflin
approved these changes
Mar 27, 2024
|
Thanks, I adjusted the commit message a bit to make it clear we didn't drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops testing 8.x branch with ES 7 as we don't support it anymore