Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChatGPT Conversations Reader #16801

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

ChatGPT Conversations Reader #16801

wants to merge 9 commits into from

Conversation

jasonnathan
Copy link

Description

Created a custom reader for ChatGPT conversations reader (and a Message Node Parser)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No (Package is new)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 3, 2024
@jasonnathan jasonnathan changed the title Completed import to llama_index project ChatGPT Conversations Reader Nov 3, 2024
@logan-markewich logan-markewich self-assigned this Nov 8, 2024
@jasonnathan
Copy link
Author

Hi @logan-markewich, ready for your review

@jasonnathan
Copy link
Author

I saw the test failed. I'll check and get back to you shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@logan-markewich logan-markewich

Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonnathan @logan-markewich