Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoyageAI Reranker optional API Key #17310

Merged

Conversation

Adversarian
Copy link
Contributor

Description

API key was a previously a required argument for the VoyageAIRerank class but the voyageai client defaults to the VOYAGE_API_KEY environment variable if no api key is provided to its constructor. Now api_key is an optional argument to this class which is consistent with other llama-index voyage integrations.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@Adversarian Adversarian changed the title VoyageAI Reranker optional API Key and voyageai client version bump VoyageAI Reranker optional API Key Dec 18, 2024
@logan-markewich logan-markewich self-assigned this Dec 18, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) December 18, 2024 22:03
@logan-markewich logan-markewich merged commit 8ecc02a into run-llama:main Dec 18, 2024
11 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants