Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exclude text in document serialization #17341

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Fix exclude text in document serialization #17341

merged 7 commits into from
Dec 20, 2024

Conversation

Javtor
Copy link
Member

@Javtor Javtor commented Dec 20, 2024

Description

When users call model_dump(exclude={"text"}), the text field should be excluded

Fixes # (issue)

New Package?

  • No

Version Bump?

  • No

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I added new unit tests to cover this change

@Javtor Javtor requested a review from masci December 20, 2024 21:56
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@Javtor Javtor enabled auto-merge (squash) December 20, 2024 22:17
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@Javtor Javtor merged commit 46a74f5 into main Dec 20, 2024
11 checks passed
@Javtor Javtor deleted the javier/fix-text-exclude-serialization branch December 20, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich approved these changes

@masci masci Awaiting requested review from masci

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Javtor @logan-markewich