fix: prevent infinite recursion in get_article_urls #17360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
logan-markewich
approved these changes
Dec 24, 2024
jzhao62
reviewed
Dec 24, 2024
| @@ -125,9 +127,10 @@ def scrape_article( | |||
| return {"title": title, "subtitle": subtitle, "body": body, "url": url} | |||
|
|
|||
| def get_article_urls( | |||
| self, browser: Any, root_url: str, current_url: str | |||
| self, browser: Any, root_url: str, current_url: str, max_depth: int = 100 | |||
There was a problem hiding this comment.
should we track the url we visited so we do not visit it again, instead of hardcoding depth ?
There was a problem hiding this comment.
I needed a quick fix but yeah, that would be a better solution, feel free to open a PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
max_depthparameter toget_article_urlsso that we prevent infinite recursion.Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Package has no tests.