Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVIDIA Support for v2 Embedding & Reranking NIMs #17410

Conversation

raspawar
Copy link
Contributor

@raspawar raspawar commented Jan 2, 2025

NVIDIA Support for v2 Embedding & Reranking NIMs

Added Support for models:

  • nvidia/llama-3.2-nv-embedqa-1b-v2
  • nvidia/llama-3.2-nv-rerankqa-1b-v2

dimensions param for nvidia/llama-3.2-nv-embedqa-1b-v2's model

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

cc: @mattf @dglogo

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 2, 2025
@raspawar raspawar changed the title Add dimensions param for nvidia/llama-3.2-nv-embedqa-1b-v2's NVIDIA Support for v2 Embedding & Reranking NIMs Jan 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2025
@logan-markewich logan-markewich merged commit 82b8207 into run-llama:main Jan 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants