Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Plugin] - What Pet is that Anyway - v1.0.0 - Sololegends #6772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sololegends
Copy link
Contributor

What Pet is that Anyway

Adds an on-hover tooltip for everyone's !pets command so you can see what the heck those little icons actually are.

# What Pet is that Anyway

Adds an on-hover tooltip for everyones `!pets` command so you can see what the heck those little icons actually are.
@runelite-github-app
Copy link

runelite-github-app bot commented Oct 13, 2024

@LlemonDuck
Copy link
Contributor

This seems like a good contribution to core if you have not already PR'd it there.

@sololegends
Copy link
Contributor Author

I was going to, but it seemed some build reqs locked behind a repo I didn't have access to.

@LlemonDuck
Copy link
Contributor

The core client can be built just fine off the runelite/runelite repository.

https://github.com/runelite/runelite/wiki/Developer-Guide

@sololegends
Copy link
Contributor Author

sololegends commented Oct 16, 2024

I'll try to work through it again, I went through that doc and during the maven build it tried to access a maven repo which kept returning a 403.

Alright having different build issues now so that is something.. I'l work through it and get it into the core client

@sololegends
Copy link
Contributor Author

Submitted a pr with this just in the chat commands core plugin

runelite/runelite#18442

@LlemonDuck
Copy link
Contributor

@sololegends We can go ahead and merge the hub plugin version here for now if you want to pull your recent changes back over, and if the core PR gets renewed attention later then that can be separate.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 12, 2024
@sololegends
Copy link
Contributor Author

Aight, I'll get the updates synced over here as soon as I can

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 12, 2024
@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 12, 2024
ported over fixes and performance enhancements from runelite core pr
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants