Exclude symbols when checking binding types #364
+62
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes ES symbol types from unions when checking bindings.
This ensures that
nothing
andnoChange
are ignored in type checking.We remove all symbol types because it is not possible to get the details of symbol types.
This will produce false negatives when other symbols are mixed in, but I consider such situations to be rare.
Closes #207. Closes #251. Closes #316.
This PR does not resolve the issue of
ifDefined
not supportingnull
(even though Lit v3 does).It will probably be resolved when we stop treating
ifDefined
specially, or when #296 is merged.The user can use either a custom directive or
value ?? nothing
instead ofifDefined
to workaround the issue.