fix: add persistent flags to root finch command #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbirju
changed the title
chews93319
previously approved these changes
Oct 29, 2024
| @@ -79,6 +79,9 @@ var newApp = func( | |||
| // TODO: Decide when to forward --debug to the dependencies | |||
| // (e.g. nerdctl for container commands and limactl for VM commands). | |||
| rootCmd.PersistentFlags().Bool("debug", false, "running under debug mode") | |||
| rootCmd.PersistentFlags().String("namespace", "", `containerd namespace, such as "moby" for Docker, "k8s.io" for Kubernetes`) | |||
| rootCmd.PersistentFlags().String("cgroup-manager", "", `Cgroup manager to use ("cgroupfs"|"systemd")`) | |||
There was a problem hiding this comment.
Do we actually support cgroupfs cgroup manager?
There was a problem hiding this comment.
Do we actually support cgroupfs cgroup manager?
I was under the assumption that nerdctl handles this under the hood, I was just referencing this
Apologies for the delayed response, I thought I replied here.
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-persistent-flags
branch
from
85a66c0
to
f7335dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#516
Adds the global flags as persistent string flag to the root finch command. This enables the cli to display the flags when running the --help command on finch.
Description of changes:
Testing done:
Verified that the command works and display the global flags.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.