ci: auto update binary dependencies #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds automation to support upgrading SOCI and ECR Cred helper dependencies to their latest versions. Finch hardcodes the SHA of the ECR Credential Helper binary for the arm64 architecture to be used in checking for if it has been `Installed()`. However, this logic likely needs to be reworked as Finch supports both x86_64 and ARM architectures. Checking for previously installed ECR cred helper can be done in a separate PR. Signed-off-by: Gavin Inglis <[email protected]>
austinvazquez
approved these changes
Oct 30, 2023
| @@ -46,6 +46,34 @@ jobs: | |||
| run: | | |||
| ./deps/finch-core/bin/update-rootfs.sh -d ${{ secrets.DEPENDENCY_BUCKET_NAME }} | |||
|
|
|||
| - name: Check for latest SOCI version | |||
| id: soci-version-check | |||
| uses: pozetroninc/github-action-get-latest-release@d1dafdb6e338bdab109e6afce581a01858680dfb | |||
There was a problem hiding this comment.
nit: can we add comment for the tagged version? e.g. # v0.7.0
|
|
||
| - name: Check for latest ECR credential helper version | ||
| id: ecr-credential-helper-version-check | ||
| uses: pozetroninc/github-action-get-latest-release@d1dafdb6e338bdab109e6afce581a01858680dfb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds automation to support upgrading SOCI and ECR Cred helper dependencies to their latest versions. Finch hardcodes the SHA of the ECR Credential Helper binary for the arm64 architecture to be used in checking for if it has been
Installed(). However, this logic likely needs to be reworked as Finch supports both x86_64 and ARM architectures. Checking for previously installed ECR cred helper can be done in a separate PR.Issue opened to track ECR cred helper hash refactor: #663
This PR makes use of the Get Latest Release action
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.