First pass, extractcode from BookListComponent, not sure why app won'…

[NullVoxPopuli]

I couldn't get the app to boot, gettign an error, not sure why -- will look after emberconf

I only minimally tried to debug

[NodeWrapper:0 /home/nvp/Development/OpenSource/ember-data-collections-demo/app] is not a SourceNode


Stack Trace and Error Report: /tmp/error.dump.17cd729144982ef406dc502e16c7d807.log
 ELIFECYCLE  Command failed with exit code 1.

^
turns out that's resolved by renaming the directory that the repo is checked out in to not have ember-data in the path

I left some notes scattered here and there.

Main things:

• all the state involved with async wasn't captured, and there is still more to do, but I added some state to the DataWrapper to capture that
• depending on the needs of book list, the apis could still change
• the api used for calling the resource is no different than if you were to use a vanilla JS class
  • and using a vanilla JS class separately could still be a good idea.
    • though, you would need to wire up owner and destruction, which is what @link could be used for (unrelated, but in ember-resources util -- not used for resources)
    • vanilla JS classes would not compose as nicely as resources with other resources -- due to ownership and destruction linking --- but would be a fine api with all that abstracted

[NullVoxPopuli]

not really needed here since we haven't implemented this resource to by type-complete from the template

[NullVoxPopuli]

on is not used here, as there is no cleanup / request cancellation occurring.

use is not used here as there are no other resources being consumed -- but if Request was a resource from ember-data, that could be used

[NullVoxPopuli]

null-flashes only occur because we create a new state context each time tracked data changes: https://github.com/runspired/ember-data-collections-demo/pull/1/files#diff-64e5910d87bd4744480041f7b84746de88b9f83fa6fddbfbd1127d4a51a8b391R54

we could pull that up in to the outer function and avoid that problem tho, and then we wouldn't need keeplatest

[NullVoxPopuli]

to-do for me post-emberconf

[NullVoxPopuli]

also, why doesn't this happen in my test-apps?

[NullVoxPopuli]

here is what this would look like once I fix a bug with trackedFunction:

import type Store from '@ember-data/store';
import type Book from 'collection-demo/models/book';
import type { Collection } from '@ember-data/types';
import { resource, resourceFactory } from 'ember-resources';
import { TrackedFunction } from 'ember-resources/util/function';

interface FirstPageOptions {
  url: string;
  sort?: string | null;
  filter?: string | null;
  genre?: string | null;
  author?: string | null;
  page?: number | null;
  limit?: number | null;
}

export const CurrentPage = resourceFactory(
  /**
   * This way of passing args has nothing to do with resources,
   * but is just how you pass args for lazy evaluation without creating
   * an options class with its own tracked properties
   */
  (optionsFns: {
    currentUrl: () => string | null;
    firstPageOptions: () => FirstPageOptions;
    addPage: (content: Collection<unknown>) => void;
  }) => {
    let previousFirstPageOptions: FirstPageOptions | undefined;

    return resource(({ on, owner, use }) => {
      const dataWrapper = new AsyncContent<Collection<Book>>();
      const addPage = optionsFns.addPage;

      const store = owner.lookup('service:store') as unknown as Store;

      const request = use(TrackedFunction(async () => {
        const currentUrl = optionsFns.currentUrl();
        const firstPageOptions = optionsFns.firstPageOptions();

        let options = firstPageOptions;

        if (previousFirstPageOptions?.url === firstPageOptions.url) {
          options = currentUrl ? { url: currentUrl } : firstPageOptions;
        }

        const books = await store.request<Book>(options);

        return books.content;
      }));

  
      return request;
    });
  }
);

[gilest]

I couldn't get the app to boot, gettign an error, not sure why -- will look after emberconf

^ turns out that's resolved by renaming the directory that the repo is checked out in to not have ember-data in the path

emberjs/data/issues/8606